Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Port 11686 Reduce cases of mass deletion #1363

Conversation

yaelibarg
Copy link
Contributor

@yaelibarg yaelibarg commented Jan 30, 2025

Description

What - Reduce cases of mass deletion from integrations (could be because of bad api's we use or just getting {} from port on the mapping)

Why - we dont want to loose data in port

How - intreduce flag entityDeletionThreshold

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

Sorry, something went wrong.

@yaelibarg yaelibarg requested a review from a team as a code owner January 30, 2025 15:01
@yaelibarg yaelibarg changed the title [Core] Port 11686 Reduce cases of mass deletion from integration transfer go [Core] Port 11686 Reduce cases of mass deletion Jan 30, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…es-of-mass-deletion-from-integration-transfer-go
Copy link
Contributor

@ivankalinovski ivankalinovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added size/XL and removed size/M labels Feb 3, 2025
@github-actions github-actions bot added size/M and removed size/XL labels Feb 4, 2025
@yaelibarg yaelibarg merged commit c906c1c into main Feb 4, 2025
16 checks passed
@yaelibarg yaelibarg deleted the PORT-11686-investigate-options-to-reduce-cases-of-mass-deletion-from-integration-transfer-go branch February 4, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants